Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Altering validation of windows directory ownership to compare SID instead of username #50887
What does this PR do?
Alters logic checking Windows directory ownership to avoid unnecessary updates.
What issues does this PR fix or reference?
Windows folder ownership was tested by username with username and domain\username not matching properly.
Windows folder ownership is tested by more uniform SID.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
I made a bad patch in my environment so I am now aware it is not particularly easy to backport to 2018.3.3. I am personally just interested in seeing this in the 2018.3.4 release now and we are just going to deal with the bug until then. I will continue to watch for a merge. Thank you to whoever has contributed.