What does this PR do?
Fixes two unrelated bugs:
What issues does this PR fix or reference?
Commits signed with GPG?
The text was updated successfully, but these errors were encountered:
Libvirt events algorigthm converting the libvirt enums into string has a flaw that unit tests couldn't see. Libvirt python binding defines the following constants: VIR_DOMAIN_EVENT_CRASHED_PANICKED = 0 VIR_DOMAIN_EVENT_DEFINED = 0 VIR_DOMAIN_EVENT_CRASHED = 8 However VIR_DOMAIN_EVENT_CRASHED_PANICKED is the only value in this enum and thus wasn't not considered a sub-enum element. So the value 0 in enum 'VIR_DOMAIN_EVENT_' was wrongly mapped to "crashed panicked" instead of "defined". In order to safely rule this case out, check if we have an item that just ends with the subprefix without the '_'.
Setting the <memory> element in the libvirt definition just changes the maximum amount of memory. Also set the <currentMemory> amount to the same value.
garethgreenaway merged commit
Dec 18, 2018
10 checks passed
10 checks passed
WIP Ready for reviewDetails
continuous-integration/jenkins/pr-merge This commit looks goodDetails
jenkins/pr/docs The docs job has passedDetails
jenkins/pr/lint Python lint test has passedDetails
jenkins/pr/py2-centos-7 The py2-centos-7 job has passedDetails
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passedDetails
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passedDetails
jenkins/pr/py3-centos-7 The py3-centos-7 job has passedDetails
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passedDetails
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passedDetails
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.