Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for architectures for APT pkgrepo.managed states #50921

Merged
merged 3 commits into from Feb 1, 2019

Conversation

@terminalmage
Copy link
Contributor

commented Dec 19, 2018

Fixes #49894.

@do3meli

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@terminalmage what is the status of this PR?

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@do3meli It is failing the test I wrote for it, which is why it hasn't been merged yet. I'll take a look at it on Thursday.

@terminalmage terminalmage force-pushed the terminalmage:issue49894 branch from c1cdc52 to 4efecd9 Jan 30, 2019
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Ahh OK, I see the problem. I'm creating a tempfile using a decorator, which fails on non-APT systems. Will be an easy fix, I'll get that done after lunch.

@terminalmage terminalmage force-pushed the terminalmage:issue49894 branch from a936080 to c97f2c7 Jan 31, 2019
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

OK, tests should pass now, should be good to merge once done.

This will make the test fail on most platforms
@terminalmage terminalmage force-pushed the terminalmage:issue49894 branch from c97f2c7 to a35c023 Feb 1, 2019
@terminalmage terminalmage requested a review from saltstack/team-core Feb 1, 2019
@thatch45 thatch45 merged commit 1f6da6a into saltstack:2018.3 Feb 1, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@do3meli

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Cool thanks @thatch45 and @terminalmage

Willthes be merged into master as well?

@thatch45

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Yes, this will be merged forward into 2019.2 and into develop

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.