Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant overrides for ip_address/ip_interface #50962

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
None yet
2 participants
@terminalmage
Copy link
Contributor

commented Dec 21, 2018

These cause spurious logging when there are IPv6 interfaces present. Furthermore, these functions are both a) present in PY3's ipaddress module, and b) present in the backported ipaddress module used in Salt when the machine is running PY2.

Fixes #50947.

Remove redundant overrides for ip_address/ip_interface
These cause spurious logging when there are IPv6 interfaces present.
Furthermore, these functions are both a) present in PY3's ipaddress
module, and b) present in the backported ipaddress module used in Salt
when the machine is running PY2.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Dec 21, 2018

@garethgreenaway garethgreenaway merged commit bb87822 into saltstack:2018.3 Dec 21, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.