Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip.installed: Fix traceback when _find_key doesn't return a match #50963

Merged
merged 4 commits into from Jan 31, 2019

Conversation

@terminalmage
Copy link
Contributor

commented Dec 21, 2018

Fixes #50942.

@terminalmage terminalmage force-pushed the terminalmage:issue50942 branch from 8954081 to 1758b13 Jan 30, 2019
@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Jan 30, 2019
@terminalmage terminalmage force-pushed the terminalmage:issue50942 branch from 1758b13 to fa169c0 Jan 30, 2019
@terminalmage terminalmage force-pushed the terminalmage:issue50942 branch from 2c62787 to c84be3f Jan 30, 2019
@dwoz
dwoz approved these changes Jan 30, 2019
@terminalmage terminalmage merged commit 13de0b8 into saltstack:2018.3 Jan 31, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@terminalmage terminalmage deleted the terminalmage:issue50942 branch Jan 31, 2019
terminalmage added a commit to terminalmage/salt that referenced this pull request Jan 31, 2019
Pull request saltstack#50963 introduces a deprecation warning on later Python 3
releases, as the abstract base classes now live in `collections.abc`.
This fixes that deprecation warning.
garethgreenaway added a commit that referenced this pull request Feb 11, 2019
Backport #50963 to 2017.7
garethgreenaway added a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.