Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unauthenticated bind for listing LDAP groups #51010

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@amendlik
Copy link
Contributor

commented Dec 31, 2018

This fix was originally made in PR #45347, then pulled into another
branch under PR #45811, but was clobbered by c3f1587. This commit
just restores the fix.

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Allow unauthenticated bind for listing LDAP groups
This fix was originally made in PR #45347, then pulled into another
branch under PR #45811, but was clobbered by c3f1587. This commit
just restores the fix.

@amendlik amendlik requested a review from saltstack/team-core as a code owner Dec 31, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Dec 31, 2018

@amendlik It looks like there are a few failing unit tests related to LDAP. Can you look into these?

amendlik and others added some commits Dec 31, 2018

@dwoz dwoz merged commit 563d487 into saltstack:2018.3 Jan 15, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.