Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set long_description #51031

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@waynew
Copy link
Contributor

commented Jan 2, 2019

Closes #50964 by setting the long_description.

It's good to have information on PyPI if people are looking there, and this does that.

Previous Behavior

The salt package on pypi has no project description

screen shot 2019-01-02 at 4 07 21 pm

New Behavior

Now uploading to pypi should also provide a description. It did on test pypi 馃槃 :
screen shot 2019-01-02 at 4 08 48 pm

I believe this should also update the description for the salt-ssh package.

Tests written?

No(t relevant?)

Commits signed with GPG?

Yes

Set long_description
It's good to have information on PyPI if people are looking there.

---

Closes #50964

Signed-off-by: Wayne Werner <wwerner@saltstack.com>

@garethgreenaway garethgreenaway merged commit a5cebd2 into saltstack:develop Jan 2, 2019

11 checks passed

WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

@garethgreenaway can you mark this to be backported? this should go into the older releases so that they update the project description the next time they are released.

thanks!

terminalmage pushed a commit that referenced this pull request Jan 3, 2019

Erik Johnson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.