Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in index_template_present documentation #51076

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@OrangeDog
Copy link
Contributor

commented Jan 7, 2019

What does this PR do?

What issues does this PR fix or reference?

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

Yes/No

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

name
Name of the index to add

This comment has been minimized.

Copy link
@gtmanfred

gtmanfred Jan 7, 2019

Contributor

This is incorrect, it should be the index to add, not check, because if it doesn't exist, it gets added.

This comment has been minimized.

Copy link
@OrangeDog

OrangeDog Jan 7, 2019

Author Contributor

Equally, if it does exist it might get changed instead of added.
I'll leave it as it was if you prefer.

@dwoz

dwoz approved these changes Jan 8, 2019

@dwoz dwoz merged commit ce87504 into saltstack:2018.3 Jan 8, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@OrangeDog OrangeDog deleted the OrangeDog:patch-1 branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.