Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow.set_date/shadow.set_expire on F28 #51079

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Jan 7, 2019

When there are problems with SSSD, warnings are written to stderr but as long as chage succeeds, the command will exit with a zero exit code.

These two functions were returning True only when there is no CLI output, instead of checking the retcode as they should have.

This commit fixes this, allowing F28 (and any other distros which use SSSD) to properly report success/failure when there are SSSD warnings in the output from chage.

Refs saltstack/salt-jenkins#1238

Fix shadow.set_date/shadow.set_expire on F28
When there are problems with SSSD, warnings are written to stderr but
as long as chage succeeds, the command will exit with a zero exit code.

These two functions were returning True only when there is no CLI
output, instead of checking the retcode as it should have.

This commit fixes this, allowing F28 (and any other distros which use
SSSD) to properly report success/failure when there are SSSD warnings in
the output from chage.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jan 7, 2019

@garethgreenaway garethgreenaway merged commit c47b646 into saltstack:2018.3 Jan 7, 2019

9 of 10 checks passed

jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

dwoz added a commit that referenced this pull request Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.