Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fix to nxos module #51080

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Jan 7, 2019

What does this PR do?

Ensure kwargs is a list before we attempt to loop through. Similar fix to rallytime@430c462 in the proxy module.

What issues does this PR fix or reference?

#50966

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jan 7, 2019

@garethgreenaway garethgreenaway merged commit 335088b into saltstack:2018.3 Jan 7, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@UtahDave

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@garethgreenaway So this fix shows up in the 2019.2 branch, but not the v2019.2.0 tag. Is there something that needs to happen to make sure it makes into v2019.2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.