Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper exception raises (2018.3) #51097

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Jan 8, 2019

This is not logging, printf-style expansion is not performed

Fix improper KeyError raise
This is not logging, printf-style expansion is not performed

@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Jan 8, 2019

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

I found some more incorrect exception raising, I may add to this PR. Marking as Pending Changes.

@terminalmage terminalmage changed the title Fix improper KeyError raise Fix improper exception raises (2018.3) Jan 8, 2019

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

OK this should be good to merge now.

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

Fix poorly-written test
This test was confirming the incorrect prior behavior.
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

@dwoz The test was incorrectly written, it was confirming that the raised exception contained a %s in it instead of the key name.

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

It has been fixed.

@dwoz dwoz merged commit b19c990 into saltstack:2018.3 Jan 15, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:fix-keyerror-raise branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.