Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Report permission changes in test mode #51105

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Jan 9, 2019

What does this PR do?

When test=True and there are permissions changes, report it.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jan 9, 2019

@thatch45 thatch45 merged commit 5d1edfb into saltstack:develop Jan 9, 2019

11 checks passed

WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@garethgreenaway what branch does this need to be backported to?

@garethgreenaway

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

@Ch3LL 2018.3 if possible.

@Ch3LL Ch3LL referenced this pull request Jan 17, 2019

Merged

Backport #51105 to 2018.3 #51233

garethgreenaway added a commit that referenced this pull request Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.