Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018.3 azurearm py3 #51144

merged 4 commits into from Jan 15, 2019


None yet
2 participants
Copy link

commented Jan 11, 2019

What does this PR do?

Here's a suggested patch that makes the azurearm driver usable in python 3. Function object_to_dict of utils/ throws an exception in python 3 and seems overly complicated to me anyway.

What issues does this PR fix or reference?

Not sure whether an issue exists. However it also contains a fix for list_location throwing an exception which is referenced in #49883 (which should probably be a separate PR but it is just a one-liner).

The develop branch does not use object_to_dict anymore so this is only relevant for 2018.3.

jgleissner added some commits Jan 10, 2019

azurearm: fix show_instance function
Fixed exception when looking up interface ID.
Also allow resource_group to be passed via kwargs.
azurearm: fix list_locations
Adapted API call for current Azure SDK

dwoz approved these changes Jan 15, 2019

@dwoz dwoz merged commit e7f53a3 into saltstack:2018.3 Jan 15, 2019

10 checks passed

WIP Ready for review
continuous-integration/jenkins/pr-merge This commit looks good
jenkins/pr/docs The docs job has passed
jenkins/pr/lint Python lint test has passed
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.