Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #49508 to 2018.3 #51150

Merged
merged 3 commits into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@Ch3LL
Copy link
Contributor

commented Jan 11, 2019

Back-port #49508

bergmannf added some commits Sep 4, 2018

Convert to string before sending via 'publish'.
Otherwise the publish call with receive a "b''" string, which can not be used
in the functions.
Do not silently ignore errors.
At least log the occurring errors to debug and trace.
@dwoz

dwoz approved these changes Jan 12, 2019

@dwoz dwoz merged commit 3a50a57 into saltstack:2018.3 Jan 12, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@isbm

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

@meaksh we need to throw away our patch in this case and rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.