Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to mysql module to handle ALL PRIVILEGES grant #51152

Merged
merged 3 commits into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Jan 12, 2019

What does this PR do?

Add additional grants. Adding logic to handle when ALL or ALL PRIVILEGES is passed for the grant, including some logic to handle the fact that the grants are split when show grants is run for a particular user.

What issues does this PR fix or reference?

#50433

Tests written?

Tests exist.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Add additional grants. Adding logic to handle when ALL or ALL PRIVILE…
…GES is passed for the grant, including some logic to handle the fact that the grants are split when show grants is run for a particular user.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jan 12, 2019

garethgreenaway added some commits Jan 12, 2019

@dwoz

dwoz approved these changes Jan 12, 2019

@dwoz dwoz merged commit 8bb589d into saltstack:2018.3 Jan 12, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.