Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to salt-junos modules #51164

Merged
merged 91 commits into from Jan 24, 2019

Conversation

@rsmekala
Copy link
Contributor

commented Jan 14, 2019

What does this PR do?

The PR contains new features and bug fixes for Junos modules and proxy.

New features:

  • Add new API get_table under junos module and state. For example,
# salt 'proxy01' junos.get_table FPCtable fpc_pic.yml /xxx/salt/_tables/
proxy01:
    ----------
    hostname:
        teakwood
    out:
        True
    reply:
        ----------
        1:
            ----------
            desc:
                MPCE Type 3 3D
            pic_status:
                ----------
                0:
                    ----------
                    desc:
                        10x 1GE(LAN) -E SFP
                    state:
                        Present
                1:
                    ----------
                    desc:
                        10x 1GE(LAN) -E SFP
                    state:
                        Present
  • Added new options to install_os module. Options:remote_path, validate, issu, nssu

Bug fixes

  • Timeout issue not respected issue resolved.
  • State module doesn't return success in result key.

What issues does this PR fix or reference?

Tests written?

Yes

rsmekala added 30 commits Oct 12, 2018
@thatch45

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Yes we can :)
I just wanted to make sure that we had looked.

@s0undt3ch what changes need to be made to get this dep working in out tests?

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

I don't see yamlordereddictloader in the requirements file, please add it there and I'll take care of our CI states.

s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Jan 23, 2019
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Jan 23, 2019
@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Once saltstack/salt-jenkins#1263 is merged, we can re-test this.

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Actually, I'm not seeing that package being imported. Still necessary?

tests/unit/modules/test_junos.py Outdated Show resolved Hide resolved
@rsmekala

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

@s0undt3ch I have updated the requirements. Could you please make the changes and deploy the CI tests again

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Test failure is unrelated.

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Still, could you confirm?

@rsmekala

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

@s0undt3ch The CI build seems to be passing now. Can you please resolve the conversation about six module.

@thatch45 Can you please approve the review for dependency so we can proceed further with the merge.

@thatch45 thatch45 merged commit c2e4b20 into saltstack:develop Jan 24, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@thatch45 beat me to it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.