Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exceptions by passing bytes to idna #51173

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Jan 14, 2019

What does this PR do?

Avoid exceptions by passing bytes to idna (which patches socket). This also reverts PR #51161 in favor of a proper fix with regression test.

What issues does this PR fix or reference?

#51160

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz dwoz changed the title Issue51160 Avoid exceptions by passing bytes to idna Jan 15, 2019

@dwoz dwoz force-pushed the dwoz:issue51160 branch from a10cfbf to 7365a1a Jan 15, 2019

@dwoz dwoz merged commit 58eede6 into saltstack:2018.3 Jan 15, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.