Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service name in minion plist #51182

Merged
merged 3 commits into from Feb 13, 2019

Conversation

@lmf-mx
Copy link
Contributor

commented Jan 15, 2019

What does this PR do?

Fixes the service name to match Apple's conventions. Homebrew uses the paths in this plist. This is the same service name fix from twangboy/salt@23d4772. The pkg built from pkg/macos use a different install path.

What issues does this PR fix or reference?

Previous Behavior

The minion service was named "salt-minion" and failed to be targeted by service.enable in 2018.3.3. While service.enable worked in previous versions, the oldest supported version that didn't follow the convention is 2017.7

New Behavior

The minion service is named "com.saltstack.salt.minion", matching the plist naming, which uses Apple's naming convention. The service can be properly targeted by service.enable.

Tests written?

No

Commits signed with GPG?

No

lmf-mx and others added 2 commits Jan 21, 2019
@dwoz dwoz requested review from twangboy and dwoz Feb 13, 2019
@twangboy twangboy merged commit 30ce509 into saltstack:2017.7 Feb 13, 2019
6 of 10 checks passed
6 of 10 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@lmf-mx lmf-mx deleted the lmf-mx:darwin-plist-update branch Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.