Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win_lgpo_auditpol salt util on Windows #51184

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Jan 16, 2019

What does this PR do?

Calls cmd.run_all directly instead of calling it via __salt__. Apparently, you can't always use __salt__ in a util.

What issues does this PR fix or reference?

saltstack/lock#777 (comment)

Tests written?

Yes

Commits signed with GPG?

Yes

directly call cmd.run_all
Apparently, you can't always use __salt__ in a util
@dwoz

dwoz approved these changes Jan 16, 2019

@dwoz dwoz merged commit 094bd33 into saltstack:2018.3 Jan 16, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

twangboy added a commit to twangboy/salt that referenced this pull request Jan 17, 2019

@twangboy twangboy deleted the twangboy:fix_auditpol branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.