Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of reload for PY3 compatibility #51206

Merged
merged 2 commits into from Jan 22, 2019

Conversation

@terminalmage
Copy link
Contributor

commented Jan 16, 2019

This also normalizes some hacks that were in place to import reload from
importlib, so that these instances also use the compatibility function.

This also normalizes some hacks that were in place to import reload from
importlib, so that these instances also use the compatibility function.
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

Weird, I had that import there before in develop, I must have removed it accidentally in the process of backporting. Thanks for catching it, @s0undt3ch!

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

yeah, the other PR's have the import.

@terminalmage terminalmage merged commit c8e70a9 into saltstack:2018.3 Jan 22, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@terminalmage terminalmage deleted the terminalmage:fix-reload branch Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.