Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an argument is not always needed to be passed to open a file #51264

Merged
merged 4 commits into from Jan 24, 2019

Conversation

@gtmanfred
Copy link
Contributor

commented Jan 21, 2019

What does this PR do?

Sometimes this is loaded using just the default, which is 'r', and 'r' is not passed. we should still be able to open the file.

Tests written?

Yes

Commits signed with GPG?

Yes

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@saltstack/team-core this would be super nice to get into 2018.3.4, since it is pretty minor and only broken starting in 2018.3.3

Thanks,
Daniel

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

Broken by eaed033

@dmurphy18 can you take a look?

Thanks,
Daniel

salt/utils/files.py Outdated Show resolved Hide resolved
gtmanfred added 2 commits Jan 21, 2019
@gtmanfred gtmanfred force-pushed the gtmanfred:2018.3 branch from c5ddc4e to 55ea80e Jan 23, 2019
@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

ok, fixed.

@thatch45

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Are these test failures related? This is some very central code :)

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

checking.

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

Ok, test should be fixed.

@s0undt3ch s0undt3ch merged commit 253f5e4 into saltstack:2018.3 Jan 24, 2019
1 check passed
1 check passed
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.