Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix minion start issue #51274
What does this PR do?
Fixes an issue introduced by #49755 which was causing the minion to fail to start on Windows with the following error:
The issue is in a new function in the salt.utils.network salt util. It was setting the host to with the following command:
Which sets the host_ip to an IPv4Address object. This PR adds
It does this on the IPv4 portion and the IPv6 portion as well.
@aphor Please test this. I don't know how it affects the issue you were trying to fix.
Commits signed with GPG?
I went to a lot of trouble at the request of @isbm to move things towards passing around IP addresses as IP address objects instead of passing around strings. I'd like to understand how your error is happening, and why there is an attempt to do DNS resolution on an IP address.
This change works like duct tape, and I'd like to get closer to the root if we can, and fix the unit tests so we don't end up going in circles trying to fix things naïvely. This is breaking tests which run on Linux.
Leaving ipaddress instances in opts brings several problems.
I tried leaving them and only casting to string(or actually calling