Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport __context__ support from develop #51279

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@twangboy
Copy link
Contributor

commented Jan 22, 2019

What does this PR do?

Backports context support from develop. Fixes a bug with case sensitive policy names.
Improved support for SecDev.

Tests written?

No

Commits signed with GPG?

Yes

twangboy added some commits Jan 22, 2019

Add __context__ support
Fix issue with case sensitivity
Remove network.py patch
This is fixed via another PR (#51274)

@twangboy twangboy requested a review from thatch45 Jan 22, 2019

@thatch45

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

Assuming we don't get any test failures this should be good to merge

@thatch45

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@dwoz can you please review and merge this?

@dwoz

dwoz approved these changes Jan 23, 2019

@dwoz dwoz merged commit 8a89cb2 into saltstack:2018.3 Jan 23, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

Merge forward to 2019.2.0.rc1: #51300

s0undt3ch added a commit that referenced this pull request Jan 24, 2019

@twangboy twangboy deleted the twangboy:backport_lgpo branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.