Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Allow running runtests.py using tox #51312

Merged
merged 9 commits into from Jan 25, 2019

Conversation

@s0undt3ch
Copy link
Member

commented Jan 24, 2019

What does this PR do?

[2017.7] Allow running runtests.py using tox

s0undt3ch added 7 commits Dec 10, 2018
@s0undt3ch s0undt3ch requested a review from saltstack/team-core as a code owner Jan 24, 2019
@codecov

This comment has been minimized.

Copy link

commented Jan 24, 2019

Codecov Report

Merging #51312 into 2017.7 will decrease coverage by 11.98%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           2017.7   #51312       +/-   ##
===========================================
- Coverage   43.62%   31.64%   -11.99%     
===========================================
  Files        1357     1319       -38     
  Lines      228941   214300    -14641     
  Branches    50064    44813     -5251     
===========================================
- Hits        99871    67810    -32061     
- Misses     120749   138754    +18005     
+ Partials     8321     7736      -585
Flag Coverage Δ
#centos6 ?
#centos7 31.64% <66.66%> (+1.76%) ⬆️
#py2 31.64% <66.66%> (+1.45%) ⬆️
#py3 ?
#transport ?
#ubuntu1804 ?
Impacted Files Coverage Δ
salt/modules/pillar.py 50.86% <66.66%> (-14.1%) ⬇️
salt/transport/frame.py 27.27% <0%> (-42.43%) ⬇️
salt/ext/ssl_match_hostname.py 0% <0%> (-36.18%) ⬇️
salt/client/ssh/wrapper/config.py 0% <0%> (-35.96%) ⬇️
salt/output/virt_query.py 12.9% <0%> (-35.49%) ⬇️
salt/beacons/load.py 0% <0%> (-35.3%) ⬇️
salt/states/pagerduty_schedule.py 9.09% <0%> (-34.85%) ⬇️
salt/states/zfs.py 4.9% <0%> (-34.35%) ⬇️
salt/states/zabbix_mediatype.py 2.47% <0%> (-33.67%) ⬇️
salt/states/smartos.py 6.39% <0%> (-33.25%) ⬇️
... and 1152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9309639...3840af8. Read the comment docs.

@waynew
waynew approved these changes Jan 25, 2019
Copy link
Contributor

left a comment

👍

@s0undt3ch s0undt3ch merged commit 2a9bf17 into saltstack:2017.7 Jan 25, 2019
7 of 10 checks passed
7 of 10 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@s0undt3ch s0undt3ch deleted the s0undt3ch:features/tox-runtests branch Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.