Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Allow running runtests.py using tox #51313

Merged
merged 8 commits into from Jan 25, 2019

Conversation

@s0undt3ch
Copy link
Member

commented Jan 24, 2019

What does this PR do?

[2018.3] Allow running runtests.py using tox

@s0undt3ch s0undt3ch requested a review from saltstack/team-core as a code owner Jan 24, 2019
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:features/tox-runtests-2018.3 branch 3 times, most recently from 0895a43 to b0c07d9 Jan 24, 2019
@codecov

This comment has been minimized.

Copy link

commented Jan 25, 2019

Codecov Report

Merging #51313 into 2018.3 will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           2018.3   #51313      +/-   ##
==========================================
+ Coverage   32.29%   33.42%   +1.12%     
==========================================
  Files        1469     1469              
  Lines      242239   241914     -325     
  Branches    51531    50159    -1372     
==========================================
+ Hits        78231    80848    +2617     
+ Misses     155363   152140    -3223     
- Partials     8645     8926     +281
Flag Coverage Δ
#centos7 33.42% <ø> (?)
#debian8 ?
#py2 33.42% <ø> (?)
#py3 ?
#ubuntu1804 ?
Impacted Files Coverage Δ
salt/transport/frame.py 27.27% <0%> (-36.37%) ⬇️
salt/auth/ldap.py 9.8% <0%> (-20.79%) ⬇️
salt/pillar/varstack_pillar.py 72.22% <0%> (-16.67%) ⬇️
salt/utils/saltclass.py 65.26% <0%> (-12.58%) ⬇️
salt/utils/versions.py 61.87% <0%> (-12.24%) ⬇️
salt/modules/mod_random.py 51.56% <0%> (-10.94%) ⬇️
salt/modules/kmod.py 43.93% <0%> (-9.85%) ⬇️
salt/auth/pki.py 21.31% <0%> (-9.84%) ⬇️
salt/modules/qemu_img.py 68.18% <0%> (-9.1%) ⬇️
salt/utils/pycrypto.py 39.28% <0%> (-8.93%) ⬇️
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62cc11...2eafc5c. Read the comment docs.

s0undt3ch added 8 commits Jan 21, 2019
@s0undt3ch s0undt3ch force-pushed the s0undt3ch:features/tox-runtests-2018.3 branch from b0c07d9 to 2eafc5c Jan 25, 2019
@waynew
waynew approved these changes Jan 25, 2019
@s0undt3ch s0undt3ch merged commit 2c3aef7 into saltstack:2018.3 Jan 25, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@s0undt3ch s0undt3ch deleted the s0undt3ch:features/tox-runtests-2018.3 branch Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.