Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[2018.3] Fixes to x509 module and test #51324
What does this PR do?
Fixing various bits in x509 module and unit test to ensure tests arepassing on python2 & python3
What issues does this PR fix or reference?
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
dmurphy18 left a comment
Looks okay, presume the conversions to bytes out resolves the Py3 type issue of Callable
I thought the tests where failing on 'ca_cert_file.write(ca_cert)' not the assert, am I mistaken and it was the assert.