Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to x509 module and test #51324

Conversation

Projects
None yet
4 participants
@garethgreenaway
Copy link
Member

commented Jan 25, 2019

What does this PR do?

Fixing various bits in x509 module and unit test to ensure tests arepassing on python2 & python3

What issues does this PR fix or reference?

saltstack/salt-jenkins#1257

Tests written?

Updated.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested review from Ch3LL and dmurphy18 Jan 25, 2019

@dmurphy18
Copy link
Contributor

left a comment

Looks okay, presume the conversions to bytes out resolves the Py3 type issue of Callable

I thought the tests where failing on 'ca_cert_file.write(ca_cert)' not the assert, am I mistaken and it was the assert.

@s0undt3ch s0undt3ch merged commit f62cc11 into saltstack:2018.3 Jan 25, 2019

1 check passed

WIP Ready for review
Details

dwoz added a commit that referenced this pull request Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.