Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Merge forward from 2017.7 to 2018.3 #51333

Merged
merged 6 commits into from Jan 25, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented Jan 25, 2019

Conflicts:

  • .codecov.yml
ethframe and others added 5 commits Jan 21, 2019
file.check_perms raises CommandExecutionError with message that starts with
'Path not found' when file or directory was deleted between _depth_limited_walk
and actual permissions check. This error was correctly ignored for directories,
but not for files. This commit fixes error message check for files.
Fix 'Path not found' error in file.directory
Add 2017.7 codecov config
Conflicts:
  - .codecov.yml
@s0undt3ch s0undt3ch merged commit 14a84e8 into saltstack:2018.3 Jan 25, 2019
1 check passed
1 check passed
WIP Ready for review
Details
@codecov

This comment has been minimized.

Copy link

commented Jan 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (2018.3@31b921f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             2018.3   #51333   +/-   ##
=========================================
  Coverage          ?   44.63%           
=========================================
  Files             ?     1357           
  Lines             ?   228941           
  Branches          ?    50064           
=========================================
  Hits              ?   102178           
  Misses            ?   119081           
  Partials          ?     7682
Flag Coverage Δ
#centos6 29.95% <0%> (?)
#centos7 43.56% <100%> (?)
#proxy 0.55% <0%> (?)
#py2 31.01% <0%> (?)
#py3 29.88% <0%> (?)
#transport 43.56% <100%> (?)
#ubuntu1804 30.1% <0%> (?)
#windows2016 29.43% <0%> (?)
Impacted Files Coverage Δ
salt/states/file.py 55.08% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b921f...27d7a89. Read the comment docs.

@Ch3LL Ch3LL deleted the Ch3LL:merge-2018.3 branch Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.