Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[2019.2] Merge forward from 2018.3 to 2019.2 #51334
This also normalizes some hacks that were in place to import reload from importlib, so that these instances also use the compatibility function.
There doesn't appear to be any reason to parse or override it here. Also allows allows TLS connections to work.
When `wheel_async` is used, the job completes, but for the same reason we couldn't replace the signal in the first place, we fail to restore it after control is returned to the context manager. This fixes this by only adding the signal data to the `old_signals` dict when we successfully override the signal handling, so that we don't incorrectly attempt to "restore" the signal later.
dwoz merged commit
Jan 27, 2019
10 checks passed
10 checks passed
WIP Ready for reviewDetails
continuous-integration/jenkins/pr-merge This commit looks goodDetails
jenkins/pr/docs The docs job has passedDetails
jenkins/pr/lint Python lint test has passedDetails
jenkins/pr/py2-centos-7 The py2-centos-7 job has passedDetails
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passedDetails
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passedDetails
jenkins/pr/py3-centos-7 The py3-centos-7 job has passedDetails
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passedDetails
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passedDetails
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.