Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in nested outputter #51454

Merged

Conversation

@terminalmage
Copy link
Contributor

commented Jan 31, 2019

Pull request #50963 introduces a deprecation warning on later Python 3 releases, as the abstract base classes now live in collections.abc. This fixes that deprecation warning.

Pull request #50963 introduces a deprecation warning on later Python 3
releases, as the abstract base classes now live in `collections.abc`.
This fixes that deprecation warning.
@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Docs failure is an issue in Jenkins, and this PR didn't touch docstrings anyway. This should be good to merge pending review.

@terminalmage terminalmage requested a review from saltstack/team-core Jan 31, 2019
@terminalmage terminalmage merged commit 588cb87 into saltstack:2018.3 Feb 1, 2019
9 of 10 checks passed
9 of 10 checks passed
jenkins/pr/docs The docs job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@terminalmage terminalmage deleted the terminalmage:fix-deprecation-warning branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.