Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #50556 state.orchestrate_show_sls #51465

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@ezh
Copy link
Contributor

commented Feb 1, 2019

What does this PR do?

Fix runner state.orchestrate_show_sls

What issues does this PR fix or reference?

#50556

Tests written?

No

Commits signed with GPG?

No

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

@ezh Thank you very much for the contribution. Are you able to write a regression test for this issue?

@ezh

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

@dwoz
I'm sorry. I'm overloaded.
Actually this patch is a piece of SaltStack environment that have a lot of such fixes.
I have no idea how to contribute them back since I haven't time to develop SaltStack too.

P.S. If you will open original case, You see that I point to exact line numbers with mismatch - only 3 locations. So it is easy to verify this locations by hands.

@ezh

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

@dwoz Ahhh! All checks have passed. You finally fix your test suites! I have never seen this before! Congratz!

@dwoz
dwoz approved these changes Feb 13, 2019
@dwoz dwoz merged commit 884981f into saltstack:2018.3 Feb 13, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
NicolasT added a commit to scality/metalk8s that referenced this pull request Apr 24, 2019
In Salt 2018.3 and 2019.2, the `state.orchestrate_show_sls` runner is
broken. There's a patch merged in the current development version,
however.

This PR adds the fixed version to the `metalk8s_saltutil` runner module
for now.

See: saltstack/salt#50556
See: saltstack/salt#51465
See: saltstack/salt#51951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.