Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent `get_locale` from working when running under Suse docker containers #51469

Merged
merged 1 commit into from Feb 17, 2019

Conversation

@s0undt3ch
Copy link
Member

commented Feb 1, 2019

What does this PR do?

Don't prevent get_locale from working when running under Suse docker containers

What issues does this PR fix or reference?

None?

Previous Behavior

When running under docker, even though the system has the required information, salt was prevented from getting it.

New Behavior

Now also works under Docker containers

Tests written?

No

Commits signed with GPG?

Yes

@s0undt3ch s0undt3ch requested a review from isbm Feb 1, 2019
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 1, 2019
…r containers

saltstack/salt#51469
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 1, 2019
…r containers

saltstack/salt#51469
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 1, 2019
…r containers

saltstack/salt#51469
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 2, 2019
…r containers

saltstack/salt#51469
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 2, 2019
…r containers

saltstack/salt#51469
s0undt3ch added a commit to s0undt3ch/salt-jenkins that referenced this pull request Feb 2, 2019
…r containers

saltstack/salt#51469
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@isbm Ping! Can you take a look and review this one?

@isbm
isbm approved these changes Feb 13, 2019
Copy link
Contributor

left a comment

This seems correct (as of today). On newer systems this will be applied with different tools, while on SLE11 and 12 will work fine.

@s0undt3ch s0undt3ch force-pushed the s0undt3ch:hotfix/fix-suse-locale-docker branch from 684b67b to 14f49b5 Feb 13, 2019
@s0undt3ch s0undt3ch merged commit a475b70 into saltstack:2018.3 Feb 17, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.