Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing dns test on Windows #51471

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Feb 1, 2019

What does this PR do?

Gets the name of the first interface on the system. Windows network interfaces don't have the same name across Window systems. You can even go as far as naming them whatever you want. The test was failing because the interface name was hard-coded as 'Ethernet'.

What issues does this PR fix or reference?

found in jenkins

Tests written?

Yes

Commits signed with GPG?

Yes

Fix the failing dns test on Windows
Gets the name of the first interface on the system. Windows network
interfaces don't have the same name across Window systems. YOu can even
go as far as naming them whatever you want. The test was failing because
the interface name was hard-coded as 'Ethernet'.

@twangboy twangboy added the 2018.3.4 label Feb 1, 2019

@dwoz

dwoz approved these changes Feb 1, 2019

@dwoz

dwoz approved these changes Feb 1, 2019

@s0undt3ch
Copy link
Member

left a comment

CentOS 7 Failure unrelated.

@s0undt3ch s0undt3ch merged commit 892d98c into saltstack:2018.3.4 Feb 3, 2019

1 check passed

WIP Ready for review
Details

@twangboy twangboy deleted the twangboy:fix_test_win_dns_client branch Feb 4, 2019

@twangboy twangboy referenced this pull request Feb 6, 2019

Merged

Backport 51471 #51528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.