Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51501 states boto3 route53.py fails to validate alias a records #51502

Conversation

@martin-paulus
Copy link
Contributor

commented Feb 5, 2019

What does this PR do?

Enable boto3_route53 state to correctly handle ALIAS (A-record) validation.

What issues does this PR fix or reference?

51501

Previous Behavior

Previously, boto3_route53.rr_present would crash on validating an existing ALIAS record.

New Behavior

Now, boto3_route53.rr_present is able to correctly create, update, validate ALIAS records.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@martin-paulus martin-paulus force-pushed the ogd-software:51501-states-boto3_route53.py-fails-to-validate-ALIAS-A-records branch from 456d437 to 5093406 Feb 5, 2019
…idate-ALIAS-A-records
@dwoz
dwoz approved these changes Feb 22, 2019
@dwoz dwoz merged commit e04f735 into saltstack:2017.7 Feb 22, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@anitakrueger

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@dwoz Is this going to be merged into 2019.2 as well by any chance? We are managing lots of ALIAS records with this state and it creates them over and over again because they are not correctly validated at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.