Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes in solarisips #51523

Merged
merged 5 commits into from Feb 13, 2019

Conversation

@lomeroe
Copy link
Contributor

commented Feb 6, 2019

What does this PR do?

Corrects two bugs in the solarisips module:

  1. #50874 - where pkg.install would not accept a list of packages
  2. Unreported bug where multiple package names were improperly quoted (i.e. "package1 package2" instead of "package1" "pacakge2") when being passed to the pkg command, which would cause the install to fail

What issues does this PR fix or reference?

#50874

Previous Behavior

Unable to use pkg.install to install a list of packages or a dict of packages

New Behavior

pkg.install allows passing "pkgs" as a list or a dict of names/versions and properly passes the package names to the pkg install command

Tests written?

Yes

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

lomeroe added 4 commits Feb 5, 2019
pkg.installed state).

Fixes #50874

Also, corrects an issue where a trailing space was added to package
names when pkgs was passed as a dict (i.e. pkg.installed state)
@lomeroe lomeroe force-pushed the lomeroe:solarisips_fixes branch from 06b37cb to b7bfe17 Feb 7, 2019
@dwoz
dwoz approved these changes Feb 13, 2019
@dwoz dwoz merged commit fdb13a3 into saltstack:2018.3 Feb 13, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.