Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3.4] Updating the mysql module to handle MariDB versions. #51530

Conversation

@garethgreenaway
Copy link
Member

commented Feb 6, 2019

What does this PR do?

Updating the mysql module to handle MariDB versions.

What issues does this PR fix or reference?

#48204

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from Ch3LL Feb 6, 2019
@Ch3LL
Ch3LL approved these changes Feb 6, 2019
@Oloremo

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

I have concerns about the line:
https://github.com/saltstack/salt/pull/51530/files#diff-29a8d4513061a20d02e36c542ea18e19R1870

It's checks version too and I'm not sure if it's right for MariaDB

@garethgreenaway

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@Oloremo I think you may be right here, it appears that "ALL PRIVILEGES" still works in later versions of MariaDB.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:48204_mysql_module_handle_mariadb_versions branch from c27b63e to cdf5298 Feb 7, 2019
@garethgreenaway

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@Oloremo Updated the PR with a workaround for MariaDB in grant_exists.

@Oloremo

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Looks good to me.

@Ch3LL Ch3LL merged commit 5b41af3 into saltstack:2018.3.4 Feb 7, 2019
8 of 10 checks passed
8 of 10 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.