Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixing schedule when enabled/disabled and saved #51610

Conversation

@garethgreenaway
Copy link
Member

commented Feb 12, 2019

What does this PR do?

When looping through the schedule to remove hidden attributes, we should only do that if the item in question is a dictionary. It could be the attribute that determines if the entire schedule is enabled or disable.

What issues does this PR fix or reference?

#51600 #51266

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Feb 12, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@garethgreenaway It looks like the test failures might be related.

…uld only do that if the item in question is a dictionary. It could be the attribute that determines if the entire scheudle is enabled or disable.
…ionality works when there is an enabled attribute.
… the test_module_name_source_match check.
@garethgreenaway garethgreenaway force-pushed the garethgreenaway:51266_schedule_enable_disable_break_save branch from 6d9f819 to 0760133 Feb 13, 2019
@garethgreenaway garethgreenaway merged commit abd3760 into saltstack:2018.3 Feb 14, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.