Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_pillar: Fix all_saltenvs on base env #51661

Merged
merged 3 commits into from Apr 18, 2019

Conversation

@sathieu
Copy link
Contributor

commented Feb 15, 2019

What does this PR do?

Fixes #50768.

What issues does this PR fix or reference?

PR #50768. This fix was too lake for 2018.3.4 (see #51597).

Previous Behavior

minion:
    Data failed to compile:
----------
    Pillar failed to render with the following messages:
----------
    Specified SLS 'projects.gitlab' in environment 'prod' is not available on the salt master

New Behavior

State applies succesfully.

Tests written?

Yes

Commits signed with GPG?

Yes

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@terminalmage please review and merge.

@dwoz dwoz requested a review from terminalmage Feb 15, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@sathieu are you able to write a test for this?

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@dwoz:

@sathieu are you able to write a test for this?

In progress.

@sathieu sathieu force-pushed the sathieu:fix50768_2018.3.5 branch from 02aa2d9 to 0c38fa8 Mar 7, 2019
@sathieu sathieu force-pushed the sathieu:fix50768_2018.3.5 branch from 0c38fa8 to 9a50106 Mar 15, 2019
@sathieu sathieu force-pushed the sathieu:fix50768_2018.3.5 branch from 9a50106 to fd0edb1 Mar 20, 2019
@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@dwoz I've written tests. Please merge.

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

This bugfix PR is waiting to be merged in 2018.3 (for 2018.3.5) and needs to go in 2019.2.1 too.

@twangboy twangboy merged commit 1d17f38 into saltstack:2018.3 Apr 18, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint Python lint test has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.