Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minion bootstrapping issue #51694

Merged
merged 2 commits into from Feb 21, 2019

Conversation

@assafShapira
Copy link
Contributor

commented Feb 18, 2019

"/usr/lib/python2.7/site-packages/salt/utils/cloud.py", line 472
Configuration value u'provider' needs to be set

What does this PR do?

address and issue, bootstraping salt minion with salt cloud and XEN cloud provider

What issues does this PR fix or reference?

no opend issue

Previous Behavior

provisioning a VM using XEN cloud provider will faile on minion bootstraping phase

   Failed to create VM xen-vm-01. Configuration value u'provider' needs to be set
   Traceback (most recent call last):
     File "/usr/lib/python2.7/site-packages/salt/cloud/__init__.py", line 1284, in create
       output = self.clouds[func](vm_)
     File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/xen.py", line 637, in create
       _deploy_salt_minion(name, session, vm_)
     File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/xen.py", line 674, in _deploy_salt_minion
       boot_ret = __utils__['cloud.bootstrap'](vm_, __opts__)
     File "/usr/lib/python2.7/site-packages/salt/utils/cloud.py", line 472, in bootstrap
       'provider': vm_['provider'],

New Behavior

boot strapping works

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

"/usr/lib/python2.7/site-packages/salt/utils/cloud.py", line 472
Configuration value u'provider' needs to be set
@dwoz
dwoz approved these changes Feb 21, 2019
@dwoz
dwoz approved these changes Feb 21, 2019
@dwoz dwoz merged commit 3475813 into saltstack:2018.3 Feb 21, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.