Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs sphinx ref and role terminology dead link replaced #51753

Merged
merged 8 commits into from Mar 21, 2019

Conversation

@alan-cugler
Copy link
Contributor

commented Feb 21, 2019

What does this PR do?

two links to old sphinx docs replaced to new valid sphinx docs.

Commits signed with GPG?

Yes

documentation pages.
@alan-cugler alan-cugler requested a review from saltstack/team-core as a code owner Feb 21, 2019
@alan-cugler alan-cugler changed the base branch from develop to 2017.7 Feb 21, 2019
Copy link
Contributor

left a comment

Hey, thanks for the PR!

There are actually a couple of other links in our docs: grep -Inr sphinx-doc doc will show you where the rest of them are. If you could update those as well, that'd be great!

@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Alright, all dead links replaced.

alan-cugler and others added 2 commits Feb 22, 2019
…e of sphinx docs.
@alan-cugler alan-cugler changed the base branch from 2017.7 to 2018.3 Mar 18, 2019
@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

This is ready to be merged if the PR passes review, let me know if there are any problems.

@twangboy

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@waynew Could you mark it resolved?

@waynew
waynew approved these changes Mar 21, 2019
@waynew

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@twangboy done!

garethgreenaway and others added 2 commits Mar 21, 2019
@twangboy twangboy merged commit 838a7aa into saltstack:2018.3 Mar 21, 2019
1 check passed
1 check passed
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.