Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch attribute error #51799

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@s0undt3ch
Copy link
Member

commented Feb 25, 2019

What does this PR do?

Catches an AttributeError found when running salt-call --local on Windows.

Tests written?

No

Commits signed with GPG?

Yes

@twangboy

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Is this also a problem on 2018.3?

@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

@twangboy No.

@dwoz dwoz merged commit 08e3956 into saltstack:2019.2 Mar 5, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.