Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diskusage beacon on Windows #51806

Merged
merged 5 commits into from Mar 5, 2019

Conversation

@twangboy
Copy link
Contributor

commented Feb 25, 2019

What does this PR do?

As documented the drive should be designated as C:\\. A recent PR #50188 changed the behavior to work with C:\, which was causing the documented syntax to fail.

This change allows either syntax C:\ or C:\\. Additionally, this change will make sure the driveletter is capitalized.

What issues does this PR fix or reference?

#51792

Tests written?

Yes

Commits signed with GPG?

Yes

twangboy added 5 commits Feb 25, 2019
As documented the drive should be designated as C:\\. A recent PR 50188
changed the behavior to work with C:\, which was causing the documented
syntax to fail.

This change allows either syntax C:\ or C:\\
@dwoz
dwoz approved these changes Mar 5, 2019
@dwoz dwoz merged commit 6aee2c4 into saltstack:2018.3 Mar 5, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@twangboy twangboy deleted the twangboy:fix_beacon branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.