Roster sshknownhosts#51840
Conversation
remijouannet
force-pushed
the
roster_sshknowhosts
branch
from
f4f08e5 to
564d718
Compare
|
anyone ? |
|
@remijouannet Thanks for the PR! I'll take a look at this some time today! |
|
Personally I think the addition is a good idea, and seems like it's shaping up well. Obviously some docs, and some automated tests still need to happen, but otherwise seems like a useful addition. @saltstack/team-core Should salt-ssh be able to build the roster from |
waynew
added
Feature
|
Hi everyone, |
|
Well, I guess there aren't any objections :) Couple of failing checks that may or may not be related. |
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
If I understand the complaint in Jenkins correctly, the surrounding lines should be the same length as their contents.
Give that a shot and see if it sorts the docs issue!
Co-Authored-By: remijouannet <remijouannet@gmail.com>
Co-Authored-By: remijouannet <remijouannet@gmail.com>
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Hi @remijouannet this is looking great!
The only thing it currently lacks is some tests. You could write unit or integration tests (or both). I think that tests/unit/ssh/test_roster_defaults.sh might have a reasonable example test you could look at.
Alternatively, there are also tests in tests/integration/ssh/ that you could probably look at 👍
Once you've got some tests, I think this will be totally ready to go!
|
Hi, yes really sorry i was really busy at works, I will work on this as soon as i can |
|
hi @waynew, one month later, i finally found the time to finish this PR, i did some refacto by using the new utils module "roster_matcher", include a unit test and write the documentation |
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Looks great! Just a couple of doc tweaks and then I'll ✔️ this!
Co-Authored-By: Wayne Werner <waynejwerner@gmail.com>
Co-Authored-By: Wayne Werner <waynejwerner@gmail.com>
Co-Authored-By: Wayne Werner <waynejwerner@gmail.com>
|
🎉 |
4 participants
What does this PR do?
Hello,
I developed a new roster to parse a known_hosts file and generate a roster from it,
i just want to know if that something you would merge, i haven't write the documentation or execute pep8 on the code yet
Tests written?
not yet
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.