Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Fix to schedule.list function to filter out attributes that are None #51849

Conversation

@garethgreenaway
Copy link
Member

commented Feb 26, 2019

What does this PR do?

Splay defaulting to None internally, broke schedule.present causing it to always report differences when a state is run. Updating the schedule.list function to check if an attribute is None and remove it.

What issues does this PR fix or reference?

#51824 #51647

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…t to always report differences when a state is run. Updating the schedule.list function to check if an attribute is None and remove it.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Feb 26, 2019
@sjorge
sjorge approved these changes Feb 27, 2019
Copy link
Contributor

left a comment

LGTM

@waynew
waynew approved these changes Feb 27, 2019
Copy link
Contributor

left a comment

Makes sense to me 👍

@garethgreenaway garethgreenaway merged commit 3732004 into saltstack:2019.2 Mar 1, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.