Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode mysql_version for python3 compatibility #51867

Merged
merged 7 commits into from Mar 5, 2019

Conversation

@Oloremo
Copy link
Contributor

commented Feb 27, 2019

What does this PR do?

Adds decode to the mysql version fetch so it should work with both Py2 and py3.

What issues does this PR fix or reference?

Fixes #51866

Previous Behavior

TypeError: a bytes-like object is required, not 'str'

Exception with Python 3

New Behavior

The module works with both python3 and python2.

Tests written?

No

Commits signed with GPG?

Yes

@Oloremo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Strange errors in Jenkins jobs. Not sure if they are related to the changes.

Oloremo added 2 commits Feb 28, 2019
Copy link
Collaborator

left a comment

LGTM

Oloremo added 3 commits Mar 2, 2019
@Oloremo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Once again seeing strange jenkins timeout errors, I didn't change anything, just merged some changes from origin.

@dwoz
dwoz approved these changes Mar 5, 2019
@dwoz dwoz merged commit 1bf3fc8 into saltstack:2018.3 Mar 5, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@Oloremo Oloremo deleted the Oloremo:mysql-module-fix-for-python3 branch Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.