Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename kubernetes module to kubernetesmod #51936

Merged
merged 4 commits into from Mar 6, 2019

Conversation

@gtmanfred
Copy link
Contributor

commented Mar 1, 2019

What does this PR do?

This makes sure this doesn't import the kubernetes module from
salt/modules while the kubernetes python module is not installed

What issues does this PR fix or reference?

Issue brought up in community slack

Tests written?

Yes

Commits signed with GPG?

Yes

gtmanfred added 3 commits Mar 1, 2019
This makes sure this doesn't import the kubernetes module from
salt/modules while the kubernetes python module is not installed
Copy link
Collaborator

left a comment

LGTM

@dwoz dwoz self-requested a review Mar 5, 2019
@garethgreenaway garethgreenaway merged commit 7ab1281 into saltstack:2018.3 Mar 6, 2019
3 of 10 checks passed
3 of 10 checks passed
jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint Python lint test has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.