Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Fix to test state functions to allow arguments that mod_watch uses #51937

Conversation

@garethgreenaway
Copy link
Member

commented Mar 1, 2019

What does this PR do?

Ensure the comment, changes, and result are valid arguments for various test state functions as they are valid arguments for mod_watch.

What issues does this PR fix or reference?

#51821

Previous Behavior

Using comment as an argument for fail_without_changes to use with watch would result in an
an invalid keyword argument error.

New Behavior

Various functions now accept arguments that mod_watch wants.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…us test state functions as they are valid arguments for mod_watch.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Mar 1, 2019
dwoz added 2 commits Apr 3, 2019
…arguments
…arguments
@dwoz dwoz added the 2019.2.1 label Apr 11, 2019
@dwoz
dwoz approved these changes Apr 11, 2019
@dwoz dwoz merged commit d3159cb into saltstack:2019.2 Apr 11, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.