Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieve systemd version using regex #51946

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@Ethyling
Copy link

commented Mar 2, 2019

What does this PR do?

Fix retrieving systemd version using regex as the systemd output changed.
See systemd/systemd#11230.

What issues does this PR fix or reference?

Fixes #51745

Tests written?

No

Commits signed with GPG?

No

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@Ethyling are you able to write a test for this?

Jordan Jacobelli added 2 commits Mar 2, 2019
Fixes #51745

Signed-off-by: Jordan Jacobelli <jordan@cri.epita.fr>
Signed-off-by: Jordan Jacobelli <jordan@cri.epita.fr>
@Ethyling

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

@dwoz Is this ok for you?

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@Ethyling Yes, Thank you!

@dwoz
dwoz approved these changes Mar 5, 2019
@dwoz dwoz merged commit be28623 into saltstack:2019.2 Mar 5, 2019
10 checks passed
10 checks passed
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.