Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[2019.2] Merge forward from 2018.3 to 2019.2 #51984
…3.py-fails-to-validate-ALIAS-A-records 51501 states boto3 route53.py fails to validate alias a records
As documented the drive should be designated as C:\\. A recent PR 50188 changed the behavior to work with C:\, which was causing the documented syntax to fail. This change allows either syntax C:\ or C:\\
Some code in salt._compat which checks if the value is a packed binary representation of an IPv6 address fails if the value passed is not a bytestring (i.e. a `unicode` type on PY2 or `str` type on PY3). This fixes that code when the minion ID is a 16-character string (not a bytestring). Note that the minion ID will never be a bytestring as of 2018.3.0, so this affects any 16-character minion ID when the minion ID is checked to see if it is really an IP address.
@twangboy - does these things work?
Once you get out of the context of with salt.utils.winapi.Com(), is conn still valid, because it will in the Com class, on the exit method (which happens when you get out of the with block), you do a pythoncom.CoUninitialize().
I think once you add the with context, you should put everything inside (returns too).
And BTW, I do see these traces on a machine box: