Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Swapping pchanges for changes in file state. #51992

Conversation

@garethgreenaway
Copy link
Member

commented Mar 6, 2019

What does this PR do?

Swapping pchanges for changes in file.managed state function.

What issues does this PR fix or reference?

#51932

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…ecause test=True, but could be changed by other states.
@twangboy

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@garethgreenaway Tests are failing on Windows...

@rhavenn

This comment has been minimized.

Copy link

commented Mar 11, 2019

I did manually apply this patch against branch 2019.2 commit db02b1d from this morning and it does work. This was on FreeBSD 11.2 and 12.0 via a custom package. Thanks.

@garethgreenaway garethgreenaway merged commit 3173673 into saltstack:2019.2 Apr 9, 2019
9 of 10 checks passed
9 of 10 checks passed
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.