Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed comparison of `None` with constants #52004
What does this PR do?
There are comparisons of
I work for Semmle and I noticed these issues with out LGTM code analyzer
The comparison of
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
There are comparisons of `None` with constant values (e.g. `'size' is None`) resulting in the comparison always being `True` or `False`. I replaced the constant values with variable names. I work for Semmle and I noticed these issues with out LGTM code analyzer https://lgtm.com/projects/g/saltstack/salt/alerts/?mode=tree&ruleFocus=3980086